Fixes #14538, fixes typing: IMPORTANT this is not a translation change, this is an …#14539
Open
benediktjohannes wants to merge 1 commit intosignalapp:mainfrom
Open
Fixes #14538, fixes typing: IMPORTANT this is not a translation change, this is an …#14539benediktjohannes wants to merge 1 commit intosignalapp:mainfrom
benediktjohannes wants to merge 1 commit intosignalapp:mainfrom
Conversation
…internal change of the value field for the translations Fixes typing: Important this is not a translation change, this is an internal change of the value field for the translations - another important thing to mention: This (probably) has to be changed in all language translation files as well and also in the general value context if it's wrong there as well and copied
Contributor
mtang-signal
left a comment
mtang-signal
left a comment
There was a problem hiding this comment.
Hi! For this pull request, you will also/only need to update where this is called (eg not the other translated files) which should be the xml file that uses this string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes typing: IMPORTANT this is not a translation change, this is an internal change of the value field for the translations
Contributor checklist
Fixes #1234syntaxDescription
Fixes typing: Important this is not a translation change, this is an internal change of the value field for the translations - another important thing to mention: This (probably) has to be changed in all language translation files as well and also in the general value context if it's wrong there as well and copied