Another two fixes, sorry for new PR, I found another two #14542
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorry for the new PR, I found another two issues Fixes typing: IMPORTANT this is not a translation change, this is an internal change of the value field for the translations Contributor checklist [ x] I am following the Code Style Guidelines [ x] My contribution is fully baked and ready to be merged as is Description Fixes typing: Important this is not a translation change, this is an internal change of the value field for the translations - another important thing to mention: This (probably) has to be changed in all language translation files as well and also in the general value context if it's wrong there as well and copied
Author
|
@mtang-signal @sashaweiss-signal Please review, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the new PR, I found another two issues
Fixes typing: IMPORTANT this is not a translation change, this is an internal change of the value field for the translations
Contributor checklist
[ x] I am following the Code Style Guidelines
[ x] My contribution is fully baked and ready to be merged as is
[ x] I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax
Description
Fixes typing: Important this is not a translation change, this is an internal change of the value field for the translations - another important thing to mention: This (probably) has to be changed in all language translation files as well and also in the general value context if it's wrong there as well and copied