-
Notifications
You must be signed in to change notification settings - Fork 168
[chore][CICD] More reusable workflow organization #6356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
crobert-1
wants to merge
13
commits into
signalfx:main
Choose a base branch
from
crobert-1:reusable_workflows_part_3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6356 +/- ##
=======================================
Coverage 44.93% 44.94%
=======================================
Files 390 390
Lines 27010 27010
=======================================
+ Hits 12137 12139 +2
+ Misses 14006 14004 -2
Partials 867 867 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
727a28e
to
0551e72
Compare
95b333f
to
9ce9aea
Compare
hughesjj
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Summary of changes:
reusable-
to make reusable workflows easier to find, and more obvious which workflows are top-level caller workflows, and which are the called workflows. The original goal was to have them all under the workflow subdirectory.github/workflows/reusable/
but this is not a supported feature of GitHub yet: https://github.com/orgs/community/discussions/10773.chef-test
workflow to use reusable functionality. Chef tests were updated in parallel with reusable workflows, so it wasn't updated as a part of the original PRs.cross-compile
andsetup-environment
references that had been missed previously.GO_VERSION
env variablesPIP_CACHE
input variable since it doesn't change based on caller.