Skip to content

[chore][CICD] More reusable workflow organization #6356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

crobert-1
Copy link
Contributor

@crobert-1 crobert-1 commented Jun 23, 2025

Description:

Summary of changes:

  1. Move reusable workflows to have their filenames prefixed with reusable- to make reusable workflows easier to find, and more obvious which workflows are top-level caller workflows, and which are the called workflows. The original goal was to have them all under the workflow subdirectory .github/workflows/reusable/ but this is not a supported feature of GitHub yet: https://github.com/orgs/community/discussions/10773.
  2. Update chef-test workflow to use reusable functionality. Chef tests were updated in parallel with reusable workflows, so it wasn't updated as a part of the original PRs.
  3. Clean up some more cross-compile and setup-environment references that had been missed previously.
  4. Remove unused GO_VERSION env variables
  5. Remove PIP_CACHE input variable since it doesn't change based on caller.

Copy link

codecov bot commented Jun 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.94%. Comparing base (178d920) to head (2dacfcc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6356   +/-   ##
=======================================
  Coverage   44.93%   44.94%           
=======================================
  Files         390      390           
  Lines       27010    27010           
=======================================
+ Hits        12137    12139    +2     
+ Misses      14006    14004    -2     
  Partials      867      867           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@crobert-1 crobert-1 force-pushed the reusable_workflows_part_3 branch from 727a28e to 0551e72 Compare June 23, 2025 23:53
@crobert-1 crobert-1 force-pushed the reusable_workflows_part_3 branch from 95b333f to 9ce9aea Compare June 24, 2025 20:54
@crobert-1 crobert-1 marked this pull request as ready for review June 24, 2025 22:27
@crobert-1 crobert-1 requested review from a team as code owners June 24, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants