Skip to content

[ansible][windows] Add option to set service CLI args #6371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

pjanotti
Copy link
Contributor

Analog implementation done to Linux via #6270 (changes to README and CHANGELOG were made via #6270).

Copy link

codecov bot commented Jun 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.97%. Comparing base (725fa07) to head (cbb8eef).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6371      +/-   ##
==========================================
+ Coverage   44.94%   44.97%   +0.02%     
==========================================
  Files         390      390              
  Lines       27010    27010              
==========================================
+ Hits        12139    12147       +8     
+ Misses      14004    13998       -6     
+ Partials      867      865       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pjanotti pjanotti marked this pull request as ready for review June 27, 2025 22:57
@pjanotti pjanotti requested review from a team as code owners June 27, 2025 22:57
Copy link
Contributor

@crobert-1 crobert-1 Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the added checks (link):

  TASK [Get splunk-otel-collector service ImagePath] *****************************
  ok: [2019] => {"changed": false, "exists": false}
  
  TASK [Assert service ImagePath ends with splunk_otel_collector_command_line_args] ***
  skipping: [2019] => {"changed": false, "false_condition": "splunk_otel_collector_command_line_args is defined", "skip_reason": "Conditional result was False"}

This means the added verification steps are currently a no-op, is that what's expected?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, fixing it ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants