Skip to content

Migrate splunk ta otel collector to golang #6526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

hughesjj
Copy link
Contributor

@hughesjj hughesjj commented Aug 2, 2025

This migrates the addon Splunk_TA_otel to a golang version, which should be easier to maintain long term.

The idea is we could get rid of maintaining two scripts (the .cmd and .sh), and instead vend binaries. This also makes signal passing much easier to the Otel TA.

Even better would be to modify cmd/otelcol to vend an additional binary that waits for modinput-like xml on startup, but we decided against this when talking about such a ~year ago

Copy link

codecov bot commented Aug 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.00%. Comparing base (4921a1b) to head (45acec6).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6526       +/-   ##
===========================================
+ Coverage   33.27%   44.00%   +10.72%     
===========================================
  Files         365      376       +11     
  Lines       26044    26459      +415     
===========================================
+ Hits         8667    11644     +2977     
+ Misses      16465    13984     -2481     
+ Partials      912      831       -81     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hughesjj hughesjj force-pushed the migrate_splunk_ta_otel_collector_to_golang branch from 348fbf6 to 4df0f98 Compare August 2, 2025 00:59
@hughesjj hughesjj force-pushed the migrate_splunk_ta_otel_collector_to_golang branch from 989765a to 45acec6 Compare August 4, 2025 22:00
@pjanotti
Copy link
Contributor

pjanotti commented Aug 4, 2025

Even better would be to modify cmd/otelcol to vend an additional binary that waits for modinput-like xml on startup, but we decided against this when talking about such a ~year ago

I think a dedicated cmd as the best option in general, not to mix with the normal otelcol but a separate cmd. Anyway, there will be challenges because there are is more than a very thin wrapper under cmd/otelcol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants