Update Falcon example to use version 3 #134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Falcon 2 is rarely used, there's version 4 out there. Change the example to use version 3 of falcon which deprecates the API class in favor of App. The falcon instrumentation package in version 3 only able to inject the middleware when the App class is used.
Open
nstawski
reviewed
Nov 12, 2022
|
|
||
|
|
||
| app = falcon.API() | ||
| app = falcon.App() |
There was a problem hiding this comment.
This change plus version update should be enough. Any reason to remove tracing or change the quotation marks?
There was a problem hiding this comment.
Hey,
I'll change back to single quotes 👍🏻
I find it very confusing that Falcon is the only tracing example with a manual trace.
This repo tends to supply examples of how to instrument different frameworks. Using the SDK to start a trace manually has nothing to do with this framework or the other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Falcon 2 is rarely used, there's version 4 out there. Change the example to use version 3 of falcon which deprecates the API class in favor of App. The falcon instrumentation package in version 3 only able to inject the middleware when the App class is used.