[mod_opusfile] New featuress: bitrate settings for each samplerate, appending to existing ogg-opus, etc. #2709
+359
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samplerate limiting for encoding to files, appending capability for encoding to files, and support for all 3 options for channel mapping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now possible to:
-Append to an existing recorded file. Each appended stream becomes an additional audio stream in the ogg container.
-The ability to set different target bitrates for NB, WB, UWB, and FB, with defaults within the ranges suggested in RFC 6716 sec 2.1.1.
-The ability to limit the maximum sample sample rate for recording file, which can further limit anything set with record_sample_rate . Thus a g711u call will not be upsampled to 48 kHz, and instead can use the lower necessary bitrate for NB.
-Metadata as defined by switch_audio_col_t now gets added to the ogg container's comments.