Prevent segmentation fault - when invalid headers point to bad memory address#2918
Open
bundasmanu wants to merge 3 commits intosignalwire:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the meanwhile, my company has been having some segmentation faults.
We cant reproduce it.
After, we check the generated core-dumps, we saw that somehow a channel header points to a bad addr, and when FS tries to create the Event, crash, as the code does not have safety checks, if headers are "invalid".
Example:
This is the backtrace:
backtrace.log
simple bt output:
This PR, acts only as a precaution, and bypassing the "bad headers". The Event will not be created with these "bad headers", if they exist, other than that, seems safety, the proposed logic.
Used Freeeswitch version:
v1.10.9Distro:
CentOS 7.9