Add metric 'Number of bytes received from each topic (deduplicated)' #6431
Conversation
chong-he
added
ready-for-review
| pub(crate) fn get_size(&self) -> usize { | ||
| self.source | ||
| .as_ref() | ||
| .map_or(0, |m| 1 + sizeof_len(m.to_bytes().len())) |
There was a problem hiding this comment.
The PeerID has a fixed length by definition, we could just precompute it
| @@ -1837,7 +1837,7 @@ where | |||
|
|
|||
| // Record the received message with the metrics | |||
| if let Some(metrics) = self.metrics.as_mut() { | |||
| metrics.msg_recvd(&message.topic); | |||
| metrics.msg_recvd(&message.topic, message.get_size()); | |||
There was a problem hiding this comment.
Here you use get_size() and above we use raw_protobuf_len what motivates the difference?
There was a problem hiding this comment.
I think we should use raw_protobuf_len to obtain the byte length of received message. Message is transformed data from RawMessage and is missing some fields compared to RawMessage, so message.get_size() returns a smaller byte size than the actually received bytes.
There was a problem hiding this comment.
yeah the get_size function is unrequired we can just use raw_protobuf_len
jimmygchen
added
waiting-on-author
| pub fn hash_byte_len(&self) -> usize { | ||
| self.hash.as_bytes().len() | ||
| } |
There was a problem hiding this comment.
nit: we are only using this once and it's a one liner, no need for a function to abstract the one liner
| @@ -1837,7 +1837,7 @@ where | |||
|
|
|||
| // Record the received message with the metrics | |||
| if let Some(metrics) = self.metrics.as_mut() { | |||
| metrics.msg_recvd(&message.topic); | |||
| metrics.msg_recvd(&message.topic, message.get_size()); | |||
There was a problem hiding this comment.
yeah the get_size function is unrequired we can just use raw_protobuf_len
Issue Addressed
This PR addresses issue #6018, the list of the additional PeerDAS metrics.
Proposed Changes
topic_msg_recv_bytesmetric intotopic_msg_recv_bytes_unfiltered. This can be a critical change, but needed to put metrics in order.topic_msg_recv_bytesas deduplicated.