Generalize sync block lookup tests #6498
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
As noted in
The existing range sync tests should adopt the event-driven style of block lookup tests.
Proposed Changes
This PR just moves the existing tests to a new directory structure so git doesn't trip and retains all the sweet blame in the 3000 lines of code of lookup tests. A future PR will migrate the range sync tests.
The idea is that lookup and range will each
impl TestRig
for what they need to keep code separate. The common functions can either be madepub(crate)
(if already inlookups.rs
) or moved tomod.rs
.