chore(validator_client): Read genesis time and genesis validators root from eth2_network_config #8638
+22
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t from eth2_network_config first at start up
|
|
Member
|
Hey @jimmychu0807 , I see your message on Discord but thought I will reply here as it is PR-related. The CLA doesn't look like it is signed, can you do that again? It would be great if you can fix the CI failing too, thanks |
Author
|
@chong-he cargo fmt'ed |
Author
|
@chong-he I have run most of the code in test-suite.yml/check-code step by hand and they pass now. Hopefully now it will pass all the CI test. In future, maybe I should PR to my own repo first to let the CI run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
#5019
Proposed Changes
If there is a known eth2_network_config, we read the genesis time and validators root from the config.
Other
@chong-he I made the code update, pretty much following your comment. Please take a look. Also, let me know if there is any protocol that I should follow when making PR to lighthouse repo. Thanks.