Disable stable checkpoint by default #2487
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current default setting means that deployers are required to spin up a Redis instance alongside Rekor. With this now disabled by default, deployers can choose whether they actually want to use stable checkpoints. I'm also tempted to remove the stable checkpoint feature entirely because I'm not sure anyone uses it in the intended way to enable witnessing, but since it's not supported in Rekor v2, I'll leave this as-is to avoid a breaking change. Signed-off-by: Hayden B <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2487 +/- ##
===========================================
- Coverage 66.46% 16.37% -50.09%
===========================================
Files 92 191 +99
Lines 9258 24789 +15531
===========================================
- Hits 6153 4060 -2093
- Misses 2359 20323 +17964
+ Partials 746 406 -340
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Hayden B <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current default setting means that deployers are required to spin up a Redis instance alongside Rekor. With this now disabled by default, deployers can choose whether they actually want to use stable checkpoints.
I'm also tempted to remove the stable checkpoint feature entirely because I'm not sure anyone uses it in the intended way to enable witnessing, but since it's not supported in Rekor v2, I'll leave this as-is to avoid a breaking change.
Summary
Release Note
Documentation