Add MarshalJSON to SigningConfig, fix marshaling bug #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a MarshalJSON method to SigningConfig so that clients don't have to construct the proto structure themselves. This also fixes a bug in ToServiceProtobuf where we didn't handle the validity window. Test cases have been updated as well to specify validity windows and operators, and I've verified that these tests fail without the bug fix. I've also added a vscode settings file to incldue the e2e tag for Go builds. Signed-off-by: Hayden B <[email protected]>
haydentherapper
force-pushed
the
fix-sc-bug
branch
from
3fb42ba to
a3dbbec
Compare
Signed-off-by: Hayden <[email protected]>
cmurphy
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a MarshalJSON method to SigningConfig so that clients don't have to construct the proto structure themselves. This also fixes a bug in ToServiceProtobuf where we didn't handle the validity window where end was optional. Test cases have been updated as well to specify validity windows and operators, and I've verified that these tests fail without the bug fix.
Summary
Release Note
Documentation