Select highest API version for SigningConfig services always #499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found a bug in the selection logic for SigningConfig services where a lower version service would be selected if it were newer than another service with a higher API version. Fix this issue looping through sorted versions and services until a set of services are found. Also added a test case to catch this. Signed-off-by: Hayden B <[email protected]>
haydentherapper
force-pushed
the
fix-sc-select-bug
branch
from
20f49f8 to
10308ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a bug in the selection logic for SigningConfig services where a lower version service would be selected if it were newer than another service with a higher API version. Fix this issue looping through sorted versions and services until a set of services are found. Also added a test case to catch this.
Summary
Release Note
Documentation