Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#32 Find configuration files with ".yml" suffix #42

Merged
merged 3 commits into from
Dec 9, 2024
Merged

#32 Find configuration files with ".yml" suffix #42

merged 3 commits into from
Dec 9, 2024

Conversation

JMTyndall
Copy link
Contributor

@mcsken mcsken self-requested a review December 6, 2024 20:39
@mcsken mcsken self-assigned this Dec 6, 2024
@mcsken mcsken added this to the v1.1.0 milestone Dec 6, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
check_done/config.py 98.90% <100.00%> (-1.10%) ⬇️

... and 5 files with indirect coverage changes

mcsken
mcsken requested changes Dec 6, 2024
View reviewed changes
check_done/config.py Outdated Show resolved Hide resolved
check_done/config.py Outdated Show resolved Hide resolved
tests/test_config.py Outdated Show resolved Hide resolved
tests/test_config.py Outdated Show resolved Hide resolved
tests/test_config.py Outdated Show resolved Hide resolved
@mcsken mcsken requested a review from roskakori December 6, 2024 22:43
roskakori and others added 2 commits December 7, 2024 06:21
roskakori
roskakori approved these changes Dec 7, 2024
View reviewed changes
Copy link
Contributor

@roskakori roskakori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the comments, "Resolve conversation" and the merge it.

check_done/config.py Outdated Show resolved Hide resolved
tests/test_config.py Outdated Show resolved Hide resolved
@mcsken mcsken merged commit 98284d0 into siisurit:main Dec 9, 2024
@JMTyndall JMTyndall deleted the 32-find-configuration-files-with-yml-suffix branch December 9, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roskakori roskakori roskakori approved these changes

@mcsken mcsken mcsken approved these changes

Assignees

@mcsken mcsken

Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

Find configuration files with ".yml" suffix
3 participants
@JMTyndall @roskakori @mcsken