Make all setting parameter names lower case #1939
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: We have to date used a mix of lowercase and camelCase setting parameter names. For example 'spaceskip' was lower case but 'emergencyStretch' was camelCase. Now all parameter names are expected to be fully lower case.
alerque
force-pushed
the
develop
branch
2 times, most recently
from
bf56e8f
to
4a540c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1396
Subsequent to discussion here I took a stab at making all the setting parameter names lower case. There turned out to be a lot more of them in camelCase than I had realized. I had thought they were mostly lower case with a few camel case stragglers. Normalizing them all to lower case would have made sense.
I actually like camelCase better for this use case, so with this many changes I'm wondering if this actually makes sense. What if we made them all camelCase?