Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So as to make review easier, here are several fixes before I tackle with enhancements.1
fix(packages): Empty CSL macros must be suppressed = Mentioned in passing in Can't run either
\printbibliography
or\csl:reference
. #2202 (comment)The same entries have the macro suppressed by citeproc-js, and it sounds logical (though poorly documented).
fix(packages): Invalid link on CSL DOI, PMID, PMCID with affixes = Also mentioned in the above-mentioned discussion:
fix(packages): Error handling the locator on some CSL styles = Not reported before, but MLA for instance was affected (and likely a bunch of others, we were just lucky Chicago styles have an explicit condition). Just some bad code ;)
fix(packages): Correctly honor affixes on multiple CSL citations = Not reported before, but preparing the way to support citing multiple keys in our package, I realized the logic was wrong. The CSL specs are so unclear at places.
Footnotes
Note to @jodros: The two first fixes correspond to issues I saw after fixing an (unrelated) issue of yours. This being said, there are still some weird things with UFES-ABNT, UNEAL-ABNT or ABNT-IPEA, notably places where there is either repeated punctuations (e.g.
Lorem. . Something
) or missing spacing (e.g.(Some editors, EDS.)Some collection title
). However, I see the same issues on these entries with that JavaScript-based online BiBTeX Converter, so I am unsure it's really our fault. ↩