Skip to content

CI: Add version bump check #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 9, 2025
Merged

CI: Add version bump check #55

merged 5 commits into from
Jul 9, 2025

Conversation

syyyr
Copy link
Contributor

@syyyr syyyr commented Jun 25, 2025

No description provided.

@syyyr syyyr requested a review from fvacek June 25, 2025 09:12
@syyyr syyyr force-pushed the ci-version-bump-check branch 4 times, most recently from b3036fd to e3d89fa Compare June 25, 2025 09:23
@syyyr syyyr marked this pull request as ready for review June 25, 2025 09:25
@syyyr syyyr force-pushed the ci-version-bump-check branch from 5259117 to cc0e857 Compare June 25, 2025 09:25
Copy link
Contributor

@fvacek fvacek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why libshvrpc version bump check is much shorter?

@syyyr
Copy link
Contributor Author

syyyr commented Jun 27, 2025

Good catch. I was testing the GH Actions code here, and I forgot to refactor this to use the actions. I will update this.

@syyyr syyyr marked this pull request as draft June 27, 2025 19:52
@syyyr syyyr force-pushed the ci-version-bump-check branch from cc0e857 to 4154ae9 Compare July 9, 2025 12:03
@syyyr syyyr marked this pull request as ready for review July 9, 2025 12:03
Copy link

github-actions bot commented Jul 9, 2025

Code coverage report for 3e0010c

Coverage difference

✅ All new changes were covered.

Filename Stmts Miss Cover Missing
TOTAL 0 0 +100.00%

Overall coverage

Click to expand
Filename Stmts Miss Cover Missing
src/lib.rs 9 0 100.00%
src/writer.rs 18 0 100.00%
src/json.rs 418 26 93.78% 131, 147, 225, 253, 263, 271, 284, 325-339, 355, 400-402, 414-415, 524
src/metamap.rs 106 34 67.92% 44-51, 67-72, 86-93, 99, 126-143
src/reader.rs 64 5 92.19% 20-22, 65, 83
src/cpon.rs 526 85 83.84% 35-37, 41, 45-47, 55, 60, 65-67, 80, 84-86, 100, 107-114, 133-154, 166-205, 308-309, 337-338, 344, 366, 379-383, 413, 429, 455-460, 497, 499-503, 518, 640
src/chainpack.rs 636 15 97.64% 87, 120, 270-282, 287, 524
src/datetime.rs 161 59 63.35% 22-27, 80-84, 92, 98-103, 107-109, 130, 135-137, 143-144, 154-155, 170, 174-221
src/decimal.rs 63 25 60.32% 26-27, 47-50, 55-59, 61, 65-80
src/textrdwr.rs 236 30 87.29% 47-72, 97, 132, 135, 145, 148, 160, 168-170, 215, 231, 243, 253, 269, 311
src/rpcvalue.rs 686 178 74.05% 70, 72-76, 78, 80-81, 84-99, 126-128, 156-158, 174-176, 216-218, 257-262, 299-301, 413-425, 433, 450, 457-462, 480, 487-512, 520, 532, 559, 576, 593, 603, 613, 623, 643, 653, 663, 673, 683, 697-726, 926-943, 982-984, 988, 998, 1004-1013, 1017, 1020-1026, 1030, 1033-1038, 1042, 1054, 1066, 1072, 1078, 1081-1096, 1118-1123, 1135-1152
src/util.rs 82 43 47.56% 23, 30-76
libshvproto-macros/src/lib.rs 261 28 89.27% 13, 24, 27, 41, 110, 114-117, 131, 241, 265, 268-274, 283-287, 301, 312-315, 446
src/bin/cp2cp.rs 100 36 64.00% 97-98, 118-124, 137, 141-142, 146-176
TOTAL 3366 564 83.24%

HTML reports

You can use GitHub CLI to download HTML coverage reports and open them automatically using this command:

(cd "$(mktemp -d)" && gh run -R silicon-heaven/libshvproto-rs download -n libshvproto-cov-html-3e0010ce51f6a78cae2b1decee3855633cc127f6 && ls -1 | xargs -n1 xdg-open)

You can download the HTML reports manually here.

@syyyr
Copy link
Contributor Author

syyyr commented Jul 9, 2025

Fix CI to used the action

@syyyr syyyr requested a review from fvacek July 9, 2025 14:17
@fvacek fvacek merged commit cdd099e into master Jul 9, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants