Conversation
… volunteer period
|
is all tested, have not encountered any exceptions in the console |
|
NOWWWW its probably good (didnt think to test for that until after i submitted) |
| ev.Player.Health = originalPlayer.Health; | ||
| ev.Player.Position = originalPlayer.Position; | ||
| ev.Player.HumeShield = originalPlayer.HumeShield; | ||
| originalPlayer.Role.Set(RoleTypeId.Spectator,SpawnReason.None); |
There was a problem hiding this comment.
??????????????????? the player should become a human once they do .h, not spectator???????????
There was a problem hiding this comment.
I elected in order to avoid having to duplicate stuff, or make a weird abstraction that'd only ever be used to handle the possibility of like spectator swap or whatever.
(I genuinely do not know what terminology I should use, "Spectator Swap" sounds the best?)
I made NewVolunteer have a nullable player and then i use that as an optional variable;
and if its supplied to just treat it like a swap thingy
There was a problem hiding this comment.
gonna resolve the other ones about this area because they all kinda roll into here
…hing lumi im so sorry)
…e user to use another command
…ED TO FIGURE OUT A CONSISTENT TERMINOGLY)
LumiFae
left a comment
LumiFae
left a comment
There was a problem hiding this comment.
Honestly, just make a request system rather than rely on the volunteer system, this is very messy, sorry 😭
| /// if supplied with an original player the <see cref="SillySCP.Handlers.VolunteerHandler"/> will treat this as a replacement | ||
| /// </summary> | ||
| #nullable enable | ||
| public static void NewVolunteer(RoleTypeId role, Player? original=null) |
There was a problem hiding this comment.
| public static void NewVolunteer(RoleTypeId role, Player? original=null) | |
| public static void NewVolunteer(RoleTypeId role, Player? original = null) |
The lack of space is really irritating me 😭
|
|
||
| if (player.Role == RoleTypeId.Scp0492) | ||
| { | ||
| response = "You cannot change into a human as SCP-049-2!, try .r or .requestVolunteer to request a spectator to take your place"; |
There was a problem hiding this comment.
| response = "You cannot change into a human as SCP-049-2!, try .r or .requestVolunteer to request a spectator to take your place"; | |
| response = "You cannot change into a human as SCP-049-2!, try .r or .requestvolunteer to request a spectator to take your place"; |
Sorry, looks ugly asf
| [CommandHandler(typeof(ClientCommandHandler))] | ||
| public class RequestHuman : ICommand | ||
| { | ||
| public string Command { get; } = "RequestHuman"; |
There was a problem hiding this comment.
please lowercase for my sanity
| public string Command { get; } = "RequestHuman"; | |
| public string Command { get; } = "requesthuman"; |
|
|
||
| public string[] Aliases { get; } = ["r","rh","request"]; | ||
|
|
||
| public string Description { get; } = "request to change into a human, if you're an SCP."; // no clue what the description for this should actually be tbh |
There was a problem hiding this comment.
| public string Description { get; } = "request to change into a human, if you're an SCP."; // no clue what the description for this should actually be tbh | |
| public string Description { get; } = "Request to change into a human, if you're an SCP."; // no clue what the description for this should actually be tbh |
honestly, dead-ass should this just get closed and i try again later when Ive taken a break?; or should this just get slogged through and it gets replaced later |
|
take ur time, use this pr, ill keep it open, just lmk when u want me to review |
|
I'm completely redoing this to be in its own separate system, for organizational reasons and so I can avoid dealing with the mistakes in this by just redoing it all. (ill make a new pull when i think its ready to be scrutinized) |
2 participants
No description provided.