Skip to content

Make messages mandatory for Partner Updates #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 25, 2024
Merged

Make messages mandatory for Partner Updates #135

merged 3 commits into from
Jun 25, 2024

Conversation

Toby-Masters-SF
Copy link
Contributor

@Toby-Masters-SF Toby-Masters-SF commented Jun 19, 2024 •
edited by AgustinSilverfin
Loading

Description

Include a summary of the changes made

Fixes #123

Type of change

  • Bug fix
  • New feature
  • Breaking change

Checklist

  • README updated (if needed)
  • Version updated (if needed)
  • Documentation updated (if needed)

Notes

CLI

  • program update-reconciliation and program update-shared-part
  • method runCommandChecks() from lib/cli/utils.js
    • Takes:
      • requiredTemplateOptions: ["handle", "all] --> Want to change the required options array?
      • options: options
      • firmIdDefault: firmIdDefault
      • partnerSupported (with a default value of true)

@Toby-Masters-SF Toby-Masters-SF linked an issue Jun 19, 2024 that may be closed by this pull request
Make messages mandatory when updating the partners version of templates #123
Closed
@Toby-Masters-SF Toby-Masters-SF marked this pull request as draft June 19, 2024 16:55
@Toby-Masters-SF Toby-Masters-SF force-pushed the 123-make-messages-mandatory-when-updating-the-partners-version-of-templates branch from 7a4af65 to 35cdb8c Compare June 25, 2024 08:15
@Toby-Masters-SF Toby-Masters-SF marked this pull request as ready for review June 25, 2024 08:15
AgustinSilverfin
AgustinSilverfin approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@AgustinSilverfin AgustinSilverfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Don't forget to update the CLI version in package.json before merging

@Toby-Masters-SF Toby-Masters-SF merged commit 7036945 into main Jun 25, 2024
1 check passed
@Toby-Masters-SF Toby-Masters-SF deleted the 123-make-messages-mandatory-when-updating-the-partners-version-of-templates branch June 25, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AgustinSilverfin AgustinSilverfin AgustinSilverfin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make messages mandatory when updating the partners version of templates
2 participants
@Toby-Masters-SF @AgustinSilverfin