Skip to content

remove https from url in getAccessToken #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

JVersee
Copy link
Contributor

@JVersee JVersee commented Sep 18, 2024

Description

BASE_URL const already includes https:// in https://live.getsilverfin.com'. In the config we have to use https://in that case as well and ensure no duplicatehttps://` is being used when string interpolating.

Fixes # (link to the corresponding issue if applicable)

Type of change

  • [x ] Bug fix
  • New feature
  • Breaking change

Checklist

  • README updated (if needed)
  • Version updated (if needed)
  • Documentation updated (if needed)

Copy link
Contributor

@Toby-Masters-SF Toby-Masters-SF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Toby-Masters-SF Toby-Masters-SF marked this pull request as ready for review September 18, 2024 08:19
@Toby-Masters-SF Toby-Masters-SF merged commit d529f31 into main Sep 18, 2024
1 check passed
@Toby-Masters-SF Toby-Masters-SF deleted the jelle-fix-base-url-in-token-request branch September 18, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants