FIX Don't error if template global is null #11331
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where if template variables from a
TemplateGlobalProvider
return null and you chain off them, you'd get a null reference error.The
getObj()
method is only ever called in one place, which sets the current item in scope - so if the current item in scope is null, we just keep null as the item in scope, which results in the behaviour we expect (i.e. nulls result in just not dumping anything to the template, are falsy in if statements, etc).Manual testing steps
See reproduction steps in the issue description
Issues
null
#11330Pull request checklist