Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Add action--unlink class to unlink action #11659

Merged
merged 1 commit into from
Apr 2, 2025
Merged

FIX Add action--unlink class to unlink action #11659

merged 1 commit into from
Apr 2, 2025
+2 −2

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz mentioned this pull request Mar 30, 2025
Closed
2 tasks
@emteknetnz emteknetnz marked this pull request as ready for review March 30, 2025 23:18
GuySartorelli
GuySartorelli reviewed Apr 1, 2025
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This already has gridfield-button-unlink - why does it need a new CSS class?

@emteknetnz
Copy link
Member Author

emteknetnz commented Apr 2, 2025 •
edited
Loading

It's naming does match the existing action--delete or action--archive pattern - we have logic here https://github.com/silverstripe/silverstripe-admin/pull/1921/files#diff-8a264e403774f999ba2208cab6299df5472cbbdf43c7081b5abaf4d03ba9af72R578 to check the existance of these classes. It would be messy to use an inconsistently named class there

@GuySartorelli
Copy link
Member

I don't agree that it would be messy and there is the consideration that this patch won't work unless people upgrade both modules with this approach.

I'm not overly fussed though, and will leave the choice to you.

@GuySartorelli
Copy link
Member

@emteknetnz Can you please respond to the above?

@emteknetnz
Copy link
Member Author

I think keep things as they are in this PR

GuySartorelli
GuySartorelli approved these changes Apr 2, 2025
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works as expected.

@GuySartorelli GuySartorelli merged commit 60391b3 into silverstripe:5.3 Apr 2, 2025
19 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5.3/unlink-record branch April 2, 2025 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli