Skip to content

FIX Don't warn about missing HTTPRequest if we don't need it #11685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2025
Merged

FIX Don't warn about missing HTTPRequest if we don't need it #11685

merged 1 commit into from
Apr 10, 2025

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli mentioned this pull request Apr 9, 2025
Closed
emteknetnz
emteknetnz approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@emteknetnz emteknetnz merged commit 61e07c4 into silverstripe:6.0 Apr 10, 2025
13 checks passed
@emteknetnz emteknetnz deleted the pulls/6.0/less-warnings branch April 10, 2025 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @emteknetnz