Skip to content

FIX Change LeftAndMain class check to AdminController #11693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

emteknetnz
Copy link
Member

@@ -339,7 +339,7 @@ public function requireSudoMode(): void
// Check that the current request handler for the form is one that's used
// in an admin context where sudo mode makes sense
$classes = [
LeftAndMain::class,
AdminController::class,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also update reference to LeftAndMain to AdminController in the PHPDoc.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@emteknetnz emteknetnz force-pushed the pulls/6.0/change-ctrl branch from f5fd2b8 to ee52694 Compare April 14, 2025 23:59
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit f508fa1 into silverstripe:6.0 Apr 15, 2025
12 checks passed
@GuySartorelli GuySartorelli deleted the pulls/6.0/change-ctrl branch April 15, 2025 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants