-
Notifications
You must be signed in to change notification settings - Fork 823
FIX Allow dot notation on HTMLEditorField #11702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX Allow dot notation on HTMLEditorField #11702
Conversation
…/module-standardiser-1743034088 MNT Run module-standardiser
@GuySartorelli Is there anything you need me to do to bring this into a release? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few things to change:
- There will be no more minor releases in CMS 5 - but this is safe to merge into a patch release. Please retarget to the
5.4
branch. You will probably need to reset your commits after retargetting the PR. - Please add a test so that we can avoid this bug regressing in the future.
- Please create and link to a relevant GitHub Issue for this (or if one already exists, link to that) in the "Issues" section. We track issues, not pull requests.
- I have added back the pull request checklist which would have been there when you originally created the PR. Please tick all the boxes that apply, making sure to read the relevant documentation to ensure everything is set up correctly.
Actual functionality
This doesn't actually save the related record. It does store the value into the record in memory (same as what FormField::saveInto()
does) - but write()
is never called on the related record, which means the new value isn't saved in the database.
Are there additional steps I need to take to actually save the value, which haven't been included in the PR description?
@RuthAdele Looks like you've brought along a bunch of commits that aren't related to your change. Please reset your commits. |
Description
Currently, using dot notation in a HTMLEditorField does not save the data to the database.
No errors are thrown - the UI updates, so it appears it has saved (unless you refresh the page, you can't see that it hasn't)
This fix aligns HTMLEditorField with the dot notation allowance that is in
FormField::saveInto()
.Manual testing steps
Create a HTMLEditorField which uses dot notation. Update content and save. Check that it has saved in the database.
e.g.
Issues
Pull request checklist