FIX Fix display of empty read-only fields #11716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
commented
May 2, 2025
| $state['value'] = $this->getFormattedValue(); | ||
| $state['value'] = $this->dataValue(); |
There was a problem hiding this comment.
Required to keep the value empty in react forms, as per CMS 5 behaviour.
2 tasks
In non-react forms the casting should be `HTMLFragment` and the value
should be `<i>('none')</i>`.
In react forms the value should just be the raw empty data value.
GuySartorelli
force-pushed
the
pulls/6.0/readonly-field
branch
from
d3629ef to
d45ae46
Compare
This was referenced May 4, 2025
|
CI failures are unrelated and will be handled in silverstripe/.github#395 since they're related to those merge-ups. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Behat tests are also added in separate PRs linked in the issue.
Issue
<i>('none')</i>while read-only in CMS (v6) #11717