Skip to content

API Allow float for number of days for cookie expiry #11724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2025
Merged

API Allow float for number of days for cookie expiry #11724

merged 1 commit into from
May 7, 2025

Conversation

GuySartorelli
Copy link
Member

GuySartorelli
GuySartorelli commented May 7, 2025
View reviewed changes
src/Control/CookieJar.php
int $expiry = 90,
int $expiry,
Copy link
Member Author

@GuySartorelli GuySartorelli May 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is meant to be a unix timestamp. 90 (or any default for that matter) is NOT appropriate here.

@GuySartorelli GuySartorelli mentioned this pull request May 7, 2025
Closed
@GuySartorelli GuySartorelli marked this pull request as draft May 7, 2025 02:28
@GuySartorelli GuySartorelli marked this pull request as ready for review May 7, 2025 03:02
@emteknetnz emteknetnz merged commit cc9f0dc into silverstripe:6.0 May 7, 2025
14 checks passed
@emteknetnz emteknetnz deleted the pulls/6.0/cookie-expiry branch May 7, 2025 04:53
@emteknetnz emteknetnz mentioned this pull request May 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @emteknetnz