FIX Only include called from portion of message if not blank

[emteknetnz]

Issue #11699

[GuySartorelli]

Do we know why it's not identifying where it's called from in the first place?

[emteknetnz]

We have this code in Deprecation::notice();

    // Getting a backtrace is slow, so we only do it if we need it
    $backtrace = [];
    
    // Get the calling scope
    if ($scope == Deprecation::SCOPE_METHOD) {
        $backtrace = debug_backtrace(0);
        $caller = Deprecation::get_called_method_from_trace($backtrace, 1);
    } elseif ($scope == Deprecation::SCOPE_CLASS) {
        $backtrace = debug_backtrace(0);
        $caller = isset($backtrace[1]['class']) ? $backtrace[1]['class'] : '(unknown)';
    } else {
        $caller = false;
    }

Means that we only get the backtrace if scope is either method or class. The db:tasks deprecation message above came from SCOPE_GLOBAL

I don't have the background as to why we don't get the stacktrace in all cases, though there would presumably be a reason for the code to be the way it is. Adding support for global messages is more then I'm comfortably doing at this stage as I can see it turning into a large time sink.

I think the information provided in the message is good enough for end-users. If you find any other instances of deprecation messages not being useful enough to pinpoint where they are coming from then perhaps we resolve in a new card.

[GuySartorelli]

Ohhh interesting. Yeah agreed that adding trace for globally scoped items is out of scope for this card. I had assumed it was something not working, not something completely not implemented.

We probably need to rebuild the way we're dealing with the trace anyway, that code is a bit of a jungle, so I'd want to improve that before adding more to it.

[GuySartorelli]

LGTM