Downgrade Cypress to fix snapshots #1795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I gave up...
For context, I upgraded Cypress to v14 in #1783, which broke the snapshots because software WebGL is deprecated in the latest Chromium. So then I switched the browser to Firefox in the CI only to remember that it generates flaky snapshots... I tried switching back to Electron/Chrome and fixing the deprecation issue. After many, many attempts, the only fix I could find was to add 1s delay before taking each screenshot, which really slowed down the tests...
So in the end, I prefer to keep my sanity and downgrade Cypress. Hopefully they will address the problem soon.
I've added a note in the
CONTRIBUTINGguide so I remember the flakiness of Firefox next time around...I also restore Prettier's
proseWrapoption. I mistakenly thought it was no longer needed but it is. What caught me was that once text is wrapped onto multiple lines, it remains wrapped regardless of theproseWrapoption. I'll have to re-add this option in other projects as well, silly me 😓