Extract and test dim mapping state initialisation #1820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelboc
commented
Jun 13, 2025
loichuder
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm planning to move the dimension mapper and related utilities/styles/models to the library, because I'd like to use them in Braggy. As a first step, I extract the dim mapping state intialisation into a dedicated utility function.
While I'm at it, I add support for initialising a dim mapping state with 0 axes (for slicing scalar values, cf. my attempt in https://github.com/silx-kit/h5web/pull/1768/files#diff-123aa107dfdd1a6159a9a847361690b69a161a6551acf1c537ad0239eaa6699f). It's not needed yet, but it actually makes the new
initDimMappingfunction more robust, IMO. I also add some unit tests to cover all edge cases.