silx.test.run_tests: Updated usage of pytest #4330
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t20100
commented
May 19, 2025
Comment on lines
+84
to
+89
| def pytest_collection_modifyitems(items): | ||
| """Add warnings filters to all tests""" | ||
| for item in items: | ||
| for filter_string in _FILTERWARNINGS: | ||
| item.add_marker(pytest.mark.filterwarnings(filter_string)) | ||
|
|
There was a problem hiding this comment.
It's the only way I found to set fiterwarnings for all tests without relying on the source project containing a pytest.ini or pyproject.toml config (not an option to allow running tests from an installed package.
Alternatives:
- Embedding
pytest.iniin the Python package and use it fromsilx.test.run_tests. - Use
pytestmark, but it needs to be set in all test modules...
t20100
force-pushed
the
update-pytest
branch
2 times, most recently
from
421447c to
95dd666
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
<Module or Topic>: <Action> <Summary>(see contributing guidelines)Merge PR #4324 first!
This PR reworks the config of pytest regarding warnings.
It moves the configuration of warning raising an error/being ignored from
silx.test.run_teststo the project'sconftest.pyby using thepytest_collection_modifyitemshook.This allows using the same rules no matter how the tests are run (
pytestorsilx.test.run_tests).