Skip to content

fix Rust through CMake #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2024
Merged

fix Rust through CMake #42

merged 1 commit into from
Sep 4, 2024

Conversation

lemire
Copy link
Member

@lemire lemire commented Aug 26, 2024

This is an alternative way to benchmark against Rust. Except for the fact that Rust should be available on the machine (automatically so if you use the suggested docker container), it works automagically.

I also fixed the nlohmann_json benchmark for twitter since it did not appear to be doing much. I think I have something fairer now.

I am not 100% sure that the Rust benchmark is equivalent though I tried my best. There is a bunch of indices_start, indices_end everywhere, but they do not appear in the JSON that we are parsing. I did not want to remove them because I just don't understand what they are, but they are subject to removal. It would be nicer if the task was well defined and equivalent throughout, for all functions.

This PR is an alternative to #41

Relates to #40

@FranciscoThiesen
Copy link
Member

Thanks for this. I'll work to make sure that rust benchmark is indeed equivalent to the C++ ones.

@FranciscoThiesen FranciscoThiesen merged commit 1da96d7 into main Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants