-
Notifications
You must be signed in to change notification settings - Fork 7
InfluxDB Publisher v2 Agent #362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for more information, see https://pre-commit.ci
… influxdb-publisher-v2
BrianJKoopman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has sat for a long time, sorry about that. We're close to being able to upgrade to InfluxDB v2 in practice, so I'd like to revisit this. For additional context, InfluxDB v3 is now available and has a self-hosted server now as well (it was cloud only for a while.)
Since all we're doing is receiving data from the feeds and publishing to Influx, I went back and forth while reviewing this on whether we should abstract away the version, i.e. have a single InfluxDB publisher agent. I haven't entirely convinced myself that's a good idea. It might lead to confusion among users, and more complicated logic within the agent to handle the differences between the various client libraries.
Even if we maintain the agent split, the nature of how we package the agents means we'll be installing all of different client packages anyway. (The v2 client needs to be added to the pyproject.toml by the way.)
With the split, we could still use some different structure to avoid some of the code duplication. (This is pointed out in the inline comments below too.)
The v1 agent has lasted a long time, past when Influx has supported using v1. Once v2 is out, we should probably consider a timeline for dropping our official support of v1, as well as eventual support of v3. (In fact, since there are some dropped features between v2 and v3, like Flux, we might want that to be sooner rather than later.)
Let me know what you think.
BrianJKoopman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Made a couple of small changes, will merge once checks complete.
Description
Adds new InfluxDB Publisher v2 agent to work with InfluxDB v2 and the
influxdb_clientpackage.Motivation and Context
Required to work with InfluxDB v2.
How Has This Been Tested?
Tested on Yale's E2E system.
Types of changes
Checklist: