Adds kill_on_exit to _AgentRunner in testing #418
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the option to kill agents in tests using SIGKILL instead of SIGINT.
Motivation and Context
In my development of of the HWP emulator-based integration tests (simonsobs/socs#802) I'm finding that, though the test are working, shutting agents down with a single interrupt command sometimes does not work, and is fairly slow (~10 sec per agent for the agents that do work). I believe this could be something related how and when socket connections are closed by the emulator but I'm not entirely sure.
I have found that using a SIGKILL instead of SIGINT to shutdown agents is much faster and more reliable, and I don't really think we care about clean shutdowns at the end of states, so I think this is a good option for some tests, such as the HWP integration tests which use many different agents.
How Has This Been Tested?
This has been tested by running HWP integration tests from the PR above locally.
Types of changes
Checklist: