Skip to content

Conversation

@dpdutcher
Copy link
Contributor

New sodetlib version fixes bug in time constant analysis for detectors near saturation, and provides additional configuration parameters to control amplifier biasing.

Description

fit_tmin is again available as a parameter that can be specified. If left as None, dynamic tmin calculation is used.
Dynamic tmin calculation rewritten to rely on the stored polarity of a detector's response, rather than abs(signal)

For amplifier bias parameters, amp_{amp}_gate_volt_{min/max} are added to the dev cfg and referenced in the amplifier biasing routines.

Motivation and Context

Issues with time constant fitting of near-saturated detectors shown here:
https://docs.google.com/presentation/d/1oGefvf0J7R-OqJHX4xY_ArVm5rNWToZq-wb7sOqg1t8/edit?slide=id.g3b710008148_0_20#slide=id.g3b710008148_0_20

How Has This Been Tested?

Kyohei and Daniel have re-run bias step analyses and saw the spuriously-low time constants disappear, with results similar to the old fixed tmin=1.5 ms results.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

New sodetlib version fixes bug in time constant analysis for detectors near saturation, and provides additional configuration parameters to control amplifier biasing.
@dpdutcher
Copy link
Contributor Author

dpdutcher commented Feb 3, 2026

@BrianJKoopman seems like simonsobs/sodetlib#494 caused this test image build to fail:

[ocs-pysmurf-agent 5/9] RUN pip3 install -e .
0.856 ERROR: File "setup.py" not found. Directory cannot be installed in editable mode: /sodetlib
0.856 (A "pyproject.toml" file was found, but editable mode currently requires a setup.py based build.)
ERROR: process "/bin/sh -c pip3 install -e ." did not complete successfully: exit code: 1

@BrianJKoopman
Copy link
Member

@BrianJKoopman seems like simonsobs/sodetlib#494 caused this test image build to fail:

[ocs-pysmurf-agent 5/9] RUN pip3 install -e . 0.856 ERROR: File "setup.py" not found. Directory cannot be installed in editable mode: /sodetlib 0.856 (A "pyproject.toml" file was found, but editable mode currently requires a setup.py based build.) ERROR: process "/bin/sh -c pip3 install -e ." did not complete successfully: exit code: 1

Can you try dropping the -e? It shouldn't really be needed. If that doesn't work I can take a closer look tomorrow.

I'm pushing towards the PyPI installation for this, so we'll start installing from there soon. I just opened simonsobs/sodetlib#497.

@dpdutcher dpdutcher requested review from a team and BrianJKoopman February 3, 2026 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants