Add CentOS Stream 9 support #179
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
trevor-vaughan
commented
Apr 19, 2022
trevor-vaughan
commented
- SSG doesn't have a profile for EL9
- No SIMP repos for EL9 so those tests won't work
- Manually verified
ekohl
reviewed
May 22, 2022
trevor-vaughan
force-pushed
the
el9-support
branch
5 times, most recently
from
c3fda42 to
c7da4b1
Compare
ekohl
reviewed
Jun 17, 2022
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
Small nit, but otherwise this looks ok.
trevor-vaughan
force-pushed
the
el9-support
branch
from
c7da4b1 to
81fa572
Compare
ekohl
previously approved these changes
Jun 17, 2022
trevor-vaughan
force-pushed
the
el9-support
branch
from
81fa572 to
7eab010
Compare
Member
|
The acceptance tests are failing because they are looking in the following repos: Niether of these repopaths exist under the simp project at that path. |
trevor-vaughan
force-pushed
the
el9-support
branch
from
7eab010 to
ef8c808
Compare
ekohl
reviewed
Jun 28, 2022
ekohl
reviewed
Jun 29, 2022
Member
Author
|
This seems to work fine as long as the downstream user adds the following to their Need to get a bunch of stuff done before we can update all of the SIMP modules so this will need to hang out for full release until then. |
trevor-vaughan
force-pushed
the
el9-support
branch
from
5188f34 to
49c5662
Compare
* SSG doesn't have a profile for EL9 * No SIMP repos for EL9 so those tests won't work * Manually verified * Bump to ruby 2.6 for net-ssh updates
trevor-vaughan
force-pushed
the
el9-support
branch
from
49c5662 to
0de291f
Compare
op-ct
approved these changes
Jan 24, 2023
Member
op-ct
left a comment
op-ct
left a comment
There was a problem hiding this comment.
LGTM; worked well with simp/pupmod-simp-simp_firewalld#28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.