config-templates/module_metarefresh.php: Removed fingerprint validati… #199
php.yml
on: pull_request
Annotations
10 errors and 8 warnings
RedundantCondition:
src/ARP.php#L39
src/ARP.php:39:13: RedundantCondition: Type string for $attributemap_filename is never null (see https://psalm.dev/122)
|
RiskyTruthyFalsyComparison:
src/MetaLoader.php#L65
src/MetaLoader.php:65:14: RiskyTruthyFalsyComparison: Operand of type array<array-key, mixed>|null contains type array<array-key, mixed>, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead. (see https://psalm.dev/356)
|
PossiblyUndefinedArrayOffset:
src/MetaLoader.php#L121
src/MetaLoader.php:121:52: PossiblyUndefinedArrayOffset: Possibly undefined array key $source['src'] on array<array-key, mixed> (see https://psalm.dev/167)
|
PossiblyUndefinedArrayOffset:
src/MetaLoader.php#L131
src/MetaLoader.php:131:46: PossiblyUndefinedArrayOffset: Possibly undefined array key $source['src'] on array<array-key, mixed> (see https://psalm.dev/167)
|
PossiblyUndefinedVariable:
src/MetaLoader.php#L148
src/MetaLoader.php:148:40: PossiblyUndefinedVariable: Possibly undefined variable $data defined in try block (see https://psalm.dev/018)
|
InvalidArgument:
src/MetaLoader.php#L200
src/MetaLoader.php:200:25: InvalidArgument: Argument 2 of SimpleSAML\Module\metarefresh\MetaLoader::addMetadata expects array<array-key, SAML2\XML\md\AttributeAuthorityDescriptor>|null, but SAML2\XML\md\AttributeAuthorityDescriptor provided (see https://psalm.dev/004)
|
ArgumentTypeCoercion:
src/MetaLoader.php#L345
src/MetaLoader.php:345:50: ArgumentTypeCoercion: Argument 1 of preg_grep expects non-empty-string, but parent type string provided (see https://psalm.dev/193)
|
ArgumentTypeCoercion:
src/MetaLoader.php#L368
src/MetaLoader.php:368:32: ArgumentTypeCoercion: Argument 1 of preg_match expects non-empty-string, but parent type string provided (see https://psalm.dev/193)
|
PossiblyInvalidArgument:
src/MetaLoader.php#L368
src/MetaLoader.php:368:45: PossiblyInvalidArgument: Argument 1 of strval expects null|object|scalar, but possibly different type array<array-key, mixed>|string provided (see https://psalm.dev/092)
|
RiskyTruthyFalsyComparison:
src/MetaLoader.php#L540
src/MetaLoader.php:540:14: RiskyTruthyFalsyComparison: Operand of type int|null contains type int, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead. (see https://psalm.dev/356)
|
PropertyNotSetInConstructor:
tests/src/Controller/MetaRefreshTest.php#L20
tests/src/Controller/MetaRefreshTest.php:20:15: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest::$authsources is not defined in constructor of SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest or in any methods called in the constructor (see https://psalm.dev/074)
|
PropertyNotSetInConstructor:
tests/src/Controller/MetaRefreshTest.php#L23
tests/src/Controller/MetaRefreshTest.php:23:15: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest::$config is not defined in constructor of SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest or in any methods called in the constructor (see https://psalm.dev/074)
|
PropertyNotSetInConstructor:
tests/src/Controller/MetaRefreshTest.php#L26
tests/src/Controller/MetaRefreshTest.php:26:15: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest::$module_config is not defined in constructor of SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest or in any methods called in the constructor (see https://psalm.dev/074)
|
PropertyNotSetInConstructor:
tests/src/Controller/MetaRefreshTest.php#L29
tests/src/Controller/MetaRefreshTest.php:29:15: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest::$authUtils is not defined in constructor of SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest or in any methods called in the constructor (see https://psalm.dev/074)
|
MissingReturnType:
tests/src/Controller/MetaRefreshTest.php#L89
tests/src/Controller/MetaRefreshTest.php:89:21: MissingReturnType: Method SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest::testMetaRefresh does not have a return type, expecting void (see https://psalm.dev/050)
|
MissingPropertyType:
tests/src/MetaLoaderTest.php#L14
tests/src/MetaLoaderTest.php:14:13: MissingPropertyType: Property SimpleSAML\Test\Module\metarefresh\MetaLoaderTest::$metaloader does not have a declared type - consider SimpleSAML\Module\metarefresh\MetaLoader|null (see https://psalm.dev/045)
|
PropertyNotSetInConstructor:
tests/src/MetaLoaderTest.php#L17
tests/src/MetaLoaderTest.php:17:13: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\metarefresh\MetaLoaderTest::$config is not defined in constructor of SimpleSAML\Test\Module\metarefresh\MetaLoaderTest or in any private or final methods called in the constructor (see https://psalm.dev/074)
|
PropertyNotSetInConstructor:
tests/src/MetaLoaderTest.php#L20
tests/src/MetaLoaderTest.php:20:13: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\metarefresh\MetaLoaderTest::$tmpdir is not defined in constructor of SimpleSAML\Test\Module\metarefresh\MetaLoaderTest or in any private or final methods called in the constructor (see https://psalm.dev/074)
|