Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump the all-actions group with 3 updates #33

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Bump the all-actions group with 3 updates #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e6d6f5
Bump the all-actions group with 3 updates
dependabot[bot] Feb 14, 2024
6b41430
Fix psalm-issue
tvdijen Feb 14, 2024
31f36a9
Remove unused use-statement
tvdijen Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/php.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:
run: echo COMPOSER_CACHE="$(composer config cache-files-dir)" >> "$GITHUB_ENV"

- name: Cache composer dependencies
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: $COMPOSER_CACHE
key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
Expand Down Expand Up @@ -128,7 +128,7 @@ jobs:
run: echo COMPOSER_CACHE="$(composer config cache-files-dir)" >> "$GITHUB_ENV"

- name: Cache composer dependencies
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: $COMPOSER_CACHE
key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
Expand Down Expand Up @@ -184,7 +184,7 @@ jobs:
run: echo COMPOSER_CACHE="$(composer config cache-files-dir)" >> "$GITHUB_ENV"

- name: Cache composer dependencies
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: $COMPOSER_CACHE
key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
Expand Down Expand Up @@ -246,7 +246,7 @@ jobs:
run: echo COMPOSER_CACHE="$(composer config cache-files-dir)" >> "$env:GITHUB_ENV"

- name: Cache composer dependencies
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: $COMPOSER_CACHE
key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
Expand All @@ -265,13 +265,13 @@ jobs:
steps:
- uses: actions/checkout@v4

- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: coverage-data
path: ${{ github.workspace }}/build

- name: Codecov
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@v4
with:
token: ${{ secrets.CODECOV_TOKEN }}
fail_ci_if_error: true
Expand Down
7 changes: 1 addition & 6 deletions tests/src/Controller/MetaRefreshTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
use SimpleSAML\Configuration;
use SimpleSAML\Module\metarefresh\Controller;
use SimpleSAML\Utils;
use Symfony\Component\HttpFoundation\Request;

/**
* Set of tests for the controllers in the "metarefresh" module.
Expand All @@ -18,16 +17,16 @@
class MetaRefreshTest extends TestCase
{
/** @var \SimpleSAML\Configuration */
protected $authsources;

Check warning on line 20 in tests/src/Controller/MetaRefreshTest.php

View workflow job for this annotation

GitHub Actions / Quality control

PropertyNotSetInConstructor 

tests/src/Controller/MetaRefreshTest.php:20:15: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest::$authsources is not defined in constructor of SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest or in any methods called in the constructor (see https://psalm.dev/074)

Check warning on line 20 in tests/src/Controller/MetaRefreshTest.php

View workflow job for this annotation

GitHub Actions / Quality control

PropertyNotSetInConstructor 

tests/src/Controller/MetaRefreshTest.php:20:15: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest::$authsources is not defined in constructor of SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest or in any methods called in the constructor (see https://psalm.dev/074)

/** @var \SimpleSAML\Configuration */
protected $config;

Check warning on line 23 in tests/src/Controller/MetaRefreshTest.php

View workflow job for this annotation

GitHub Actions / Quality control

PropertyNotSetInConstructor 

tests/src/Controller/MetaRefreshTest.php:23:15: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest::$config is not defined in constructor of SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest or in any methods called in the constructor (see https://psalm.dev/074)

Check warning on line 23 in tests/src/Controller/MetaRefreshTest.php

View workflow job for this annotation

GitHub Actions / Quality control

PropertyNotSetInConstructor 

tests/src/Controller/MetaRefreshTest.php:23:15: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest::$config is not defined in constructor of SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest or in any methods called in the constructor (see https://psalm.dev/074)

/** @var \SimpleSAML\Configuration */
protected $module_config;

Check warning on line 26 in tests/src/Controller/MetaRefreshTest.php

View workflow job for this annotation

GitHub Actions / Quality control

PropertyNotSetInConstructor 

tests/src/Controller/MetaRefreshTest.php:26:15: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest::$module_config is not defined in constructor of SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest or in any methods called in the constructor (see https://psalm.dev/074)

Check warning on line 26 in tests/src/Controller/MetaRefreshTest.php

View workflow job for this annotation

GitHub Actions / Quality control

PropertyNotSetInConstructor 

tests/src/Controller/MetaRefreshTest.php:26:15: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest::$module_config is not defined in constructor of SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest or in any methods called in the constructor (see https://psalm.dev/074)

/** @var \SimpleSAML\Utils\Auth */
protected $authUtils;

Check warning on line 29 in tests/src/Controller/MetaRefreshTest.php

View workflow job for this annotation

GitHub Actions / Quality control

PropertyNotSetInConstructor 

tests/src/Controller/MetaRefreshTest.php:29:15: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest::$authUtils is not defined in constructor of SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest or in any methods called in the constructor (see https://psalm.dev/074)

Check warning on line 29 in tests/src/Controller/MetaRefreshTest.php

View workflow job for this annotation

GitHub Actions / Quality control

PropertyNotSetInConstructor 

tests/src/Controller/MetaRefreshTest.php:29:15: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest::$authUtils is not defined in constructor of SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest or in any methods called in the constructor (see https://psalm.dev/074)


/**
Expand Down Expand Up @@ -87,24 +86,20 @@

/**
*/
public function testMetaRefresh()

Check warning on line 89 in tests/src/Controller/MetaRefreshTest.php

View workflow job for this annotation

GitHub Actions / Quality control

MissingReturnType 

tests/src/Controller/MetaRefreshTest.php:89:21: MissingReturnType: Method SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest::testMetaRefresh does not have a return type, expecting void (see https://psalm.dev/050)

Check warning on line 89 in tests/src/Controller/MetaRefreshTest.php

View workflow job for this annotation

GitHub Actions / Quality control

MissingReturnType 

tests/src/Controller/MetaRefreshTest.php:89:21: MissingReturnType: Method SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest::testMetaRefresh does not have a return type, expecting void (see https://psalm.dev/050)
{
$_SERVER['REQUEST_URI'] = '/module.php/metarefresh/';
$_SERVER['REQUEST_METHOD'] = 'GET';
$_SERVER['SERVER_PROTOCOL'] = 'HTTP/1.1';

Configuration::setPreLoadedConfig($this->authsources, 'authsources.php');
$request = Request::create(
'/',
'GET'
);

$c = new Controller\MetaRefresh($this->config);
$c->setAuthUtils($this->authUtils);
$c->setModuleConfig($this->module_config);

/** @var \SimpleSAML\XHTML\Template $response */
$response = $c->main($request);
$response = $c->main();

$this->assertTrue($response->isSuccessful());

Expand Down
Loading