-
-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenID Connect #2607
base: main
Are you sure you want to change the base?
Add OpenID Connect #2607
Conversation
unicorn |
Thanks for making an Awesome list! 🙌 It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome. |
ba54fbc
to
0d0277f
Compare
After reading the guidelines again, I am still not sure what was not followed. I add more details and rephrase some parts to improve the list. The awesome-lint pass. If you have more insight into what is wrong with the list, I would be happy to fix it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description should be more explanatory and describe the theme of the list, not the list itself. A brief description of OpenID Connect is sufficient.
The letter casing and formatting in the list entry descriptions should be more consistent. For instance, you should decide between writing "Open Source" or "Open-source" and "Blog" or "blog". |
@hallvaaw Thanks for the review. The list has been changed with some improvements. Following the awesome repo guideline, the main description must be short so only a small description of what is OpenId Connect has been added. |
bc5e5cc
to
ddcb6fd
Compare
@sindresorhus This PR is ready, can you review it? |
ddcb6fd
to
027f80d
Compare
Looks good and supper useful @emmanuelgautier! |
unicorn |
|
The repo name should be |
|
027f80d
to
cb8fb13
Compare
Thanks for you review.
The PRs reviewed list has been updated in the description in order to show only those with review comments on them.
Done ✔️
Link has been updated to OpenID Connect Foundation website. ✔️ Description has been changed and is now more focused on what OpenID Connect is. Let me know if it sound more clear for you. |
cb8fb13
to
86237d9
Compare
c05ec08
to
bbe1e6f
Compare
I'm seeing both |
The "Books" section descriptions should mention the publish year. |
#2607 (comment) was not done |
Done ✔️
Good idea. It will give some insight about the writing context. Done ✔️
I should have not understand your point. Here is the current description with the link: Has you can see, the description explains quickly what is OpenID Connect and when using it. The link is the official OpenID Connect Foundation url. |
@Marcelo-Gustavo-2012 ...soi Dora? |
f0658c5
to
993cee4
Compare
I'm talking about the readme description, not the repo description. |
The main description is the same as the repository description. I’ve added more details, but I can’t add a lot more since the OpenID Connect specs cover various use cases now. This PR is a year and a half old, and it seems the conversation isn’t progressing so much. It's pity, as OpenID Connect is a widely used standard, and many people are searching for resources (libs, providers, some specs, ... etc). IMHO, this list is not so bad and can help more being listed in this repository. Anyway, It's your project, and you can take it in whatever direction you prefer. If you believe this list shouldn’t be merged for any reason, just let me know, and I’ll close the pull request to save us both time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems a pretty exhaustive list to me. I don't see any issues, +1 for merging.
https://github.com/cerberauth/awesome-openidconnect
OpenID Connect with its ecosystem is quite complex now with a lot of libraries, specs, and providers. This list tried to aggregate the different existing libraries, providers, specs, and different resources to learn more about this protocol. The goal is to help a developer or a decision-maker to enter into this topic.
PR Reviewed and commented:
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions. Comments pointing out lint violation are allowed, but does not count as a review.
Add Name of List
. It should not contain the wordAwesome
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
add Swift
Adding Swift
Added Swift
- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
#readme
.- [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.main
, notmaster
.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Contents
, notTable of Contents
.Contributing
orFootnotes
sections.https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0
(replace<user>
and<repo>
accordingly).license
orLICENSE
in the repo root with the license text.Licence
section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.unicorn
.contributing.md
. Casing is up to you.Contributing
, positioned at the top or bottom of the main content.Footnotes
section at the bottom of the readme. The section should not be present in the Table of Contents.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use a CI for linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.