Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add preferLocal and addExecaPath options #18

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Add preferLocal and addExecaPath options #18

merged 2 commits into from
Feb 22, 2024

Conversation

ehmicky
Copy link
Contributor

@ehmicky ehmicky commented Feb 21, 2024 •
edited
Loading

Fixes #17.

This also does the following:

  • Avoid repeating the same options for npmRunPathEnv() and npmRunPath() in readme.md
  • Rework types to avoid code duplication
  • Small refactoring of the main file and tests

The options default to the current behavior, i.e. this is not a breaking change.

sindresorhus
sindresorhus requested changes Feb 22, 2024
View reviewed changes
index.js Outdated Show resolved Hide resolved
@sindresorhus sindresorhus merged commit 09419af into sindresorhus:main Feb 22, 2024
1 check passed
@ehmicky ehmicky deleted the new-options branch February 22, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus Awaiting requested review from sindresorhus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decouple running local binaries and choosing the Node.js version
2 participants
@ehmicky @sindresorhus