add project_tags for space_tags #17
Open
+111
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the tags stream implementation by splitting it into two distinct streams: project_tags for project-level tags and space_tags for space-level tags. The original Tags stream (which was a child of Spaces) has been removed and replaced with these two independent streams that have different API endpoints and replication strategies.
Key Changes:
- Removed the parent-dependent
Tagsstream and replaced it with two standalone tag streams SpaceTagsuses incremental replication withupdatedAtas the replication keyProjectTagsuses full table replication and queries the projects API endpoint
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tap_teamwork/streams/tags.py | Deleted the original Tags stream class that was dependent on spaces parent |
| tap_teamwork/streams/space_tags.py | Added new SpaceTags stream with incremental replication strategy |
| tap_teamwork/streams/project_tags.py | Added new ProjectTags stream with full table replication strategy |
| tap_teamwork/streams/init.py | Updated imports and STREAMS dictionary to register the new tag streams |
| tap_teamwork/schemas/project_tags.json | Added JSON schema definition for project_tags stream |
| spike/singer_tap_generator_config.json | Updated configuration to reflect the split from tags to project_tags and space_tags |
| README.md | Updated documentation to reference the new ProjectTags and SpaceTags streams |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
…to add_tags_space_project
RushiT0122
requested changes
Nov 7, 2025
RushiT0122
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR refactors the tags stream implementation by splitting it into two distinct streams: project_tags for project-level tags and space_tags for space-level tags
(SAC-29530)
Manual QA steps
Risks
Rollback steps