Skip to content

Focus and open context menu on right click if unfocused #2477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

tjarvstrand
Copy link
Contributor

@tjarvstrand tjarvstrand commented Feb 17, 2025

Description

If the editor is not focused and the user right clicks it, nothing currently happens. With these changes the editor is now focused and the context menu opened. Similar to how TextField works

Type of Change

  • Feature: New functionality without breaking existing features.
  • 🛠️ Bug fix: Resolves an issue without altering current behavior.
  • 🧹 Refactor: Code reorganization, no behavior change.
  • Breaking: Alters existing functionality and requires updates.
  • 🧪 Tests: New or modified tests
  • 📝 Documentation: Updates or additions to documentation.
  • 🗑️ Chore: Routine tasks, or maintenance.
  • Build configuration change: Build/configuration changes.

@tjarvstrand tjarvstrand force-pushed the focus-on-secondary-click branch from bf0b2cd to e8e886e Compare February 18, 2025 14:00
@tjarvstrand tjarvstrand marked this pull request as draft February 19, 2025 08:17
@tjarvstrand tjarvstrand force-pushed the focus-on-secondary-click branch from e8e886e to ec689b4 Compare February 19, 2025 09:55
@tjarvstrand tjarvstrand force-pushed the focus-on-secondary-click branch from ec689b4 to 3436264 Compare February 19, 2025 10:00
@tjarvstrand tjarvstrand marked this pull request as ready for review February 19, 2025 10:00
Copy link
Collaborator

@CatHood0 CatHood0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@CatHood0 CatHood0 merged commit 4a2e1a3 into singerdmx:master Feb 21, 2025
7 checks passed
CatHood0 pushed a commit to CatHood0/flutter-quill that referenced this pull request Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants