Skip to content

fix: flutter_keyboard_visibility WASM build bug #2478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

geronimol
Copy link
Contributor

Description

Instead of using flutter_keyboard_visibility_temp_fork, will use the fixed version of the flutter_keyboard_visibilitypackage from the new/packages directory.

Source of the fixed package: https://github.com/raldhafiri/flutter_keyboard_visibility.git

Related Issues

Type of Change

  • Feature: New functionality without breaking existing features.
  • 🛠️ Bug fix: Resolves an issue without altering current behavior.
  • 🧹 Refactor: Code reorganization, no behavior change.
  • Breaking: Alters existing functionality and requires updates.
  • 🧪 Tests: New or modified tests
  • 📝 Documentation: Updates or additions to documentation.
  • 🗑️ Chore: Routine tasks, or maintenance.
  • Build configuration change: Build/configuration changes.

@geronimol geronimol force-pushed the keyboard-visibility-fix branch from 21ec920 to b62ad0d Compare February 17, 2025 18:58
Comment on lines +35 to +40
# The flutter_keyboard_visibility_web uses dart:html which is incompatible with WASM,
# override it with a modified version that uses the web package instead.
flutter_keyboard_visibility:
path: ../packages/flutter_keyboard_visibility/flutter_keyboard_visibility
flutter_keyboard_visibility_web:
path: ../packages/flutter_keyboard_visibility/flutter_keyboard_visibility_web
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All clients are required to include this in their project to get this fix, we cannot use packages that are not uploaded to pub.dev and when we upload, we need to change the package name to something different, the flutter_keyboard_visibility_temp_fork doesn't collide with flutter_keyboard_visibility.

flutter_keyboard_visibility_web

We use flutter_keyboard_visibility_temp_fork which doesn't have this issue.

Copy link
Collaborator

@EchoEllet EchoEllet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR fixes an issue that's not with flutter_quill or flutter_keyboard_visibility_temp_fork AFAIK so closing the PR since we don't plan to maintain a copy of flutter_keyboard_visibility on this repo.

However, thank you for your contribution!

Update: #2473 (comment)

@EchoEllet EchoEllet closed this Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Web] Issue with flutter_keyboard_visibility_web dependency when making a WASM build
2 participants