Chore: improved support for soft-keyboards on the TextInputClient #2509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CatHood0
added
enhancement
CatHood0
changed the title
CatHood0
changed the title
…ingerdmx#2483) * docs: update controller length extension method deprecation message * docs: update changelog
Co-authored-by: CatHood0 <[email protected]>
…ute (singerdmx#2438) * feat: Enable BoxDecoration for DefaultTextBlockStyle of header Attribute --------- Co-authored-by: Ellet <[email protected]>
… of page route changing when editor is set to readonly. (singerdmx#2488) Co-authored-by: chaos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, our
TextInputClientimplementation only allowed for one specific action during theupdateEditingValuecall: applying the new (or removed) text to the document. However, it didn't have good support forCharacterShorcutEventswhen applying them to virtual keyboards.For this purpose, a new implementation was created that allows for more explicit retrieval of the type of change made to the document/text and for simple application.
This description will be updated soon to provide more information on why it was done this way.
Related Issues
Type of Change