Skip to content

fix Discord prompt parameter #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
singingwolfboy merged 3 commits into from
Apr 8, 2024
Merged

fix Discord prompt parameter #433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df91b20
fix Discord prompt parameter
owencompher Apr 7, 2024
46b8361
fix tests for prompt parameter
owencompher Apr 7, 2024
b4da2eb
fix formatting
owencompher Apr 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flask_dance/contrib/discord.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def make_discord_blueprint(
scope = scope or ["identify"]
authorization_url_params = {"prompt": "consent"}
if prompt is None:
authorization_url_params["prompt"] = None
authorization_url_params["prompt"] = "none"
discord_bp = OAuth2ConsumerBlueprint(
"discord",
__name__,
Expand Down
22 changes: 20 additions & 2 deletions tests/contrib/test_discord.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,25 @@ def test_blueprint_factory():
assert discord_bp.authorization_url_params["prompt"] == "consent"


def test_blueprint_factory_with_prompt():
def test_blueprint_factory_with_prompt_consent():
discord_bp = make_discord_blueprint(
client_id="foo",
client_secret="bar",
scope=["identify", "email"],
redirect_to="index",
prompt="consent",
)
assert isinstance(discord_bp, OAuth2ConsumerBlueprint)
assert discord_bp.session.scope == ["identify", "email"]
assert discord_bp.session.base_url == "https://discord.com/"
assert discord_bp.session.client_id == "foo"
assert discord_bp.client_secret == "bar"
assert discord_bp.authorization_url == "https://discord.com/api/oauth2/authorize"
assert discord_bp.token_url == "https://discord.com/api/oauth2/token"
assert discord_bp.authorization_url_params["prompt"] == "consent"


def test_blueprint_factory_with_prompt_None():
discord_bp = make_discord_blueprint(
client_id="foo",
client_secret="bar",
Expand All @@ -54,7 +72,7 @@ def test_blueprint_factory_with_prompt():
assert discord_bp.client_secret == "bar"
assert discord_bp.authorization_url == "https://discord.com/api/oauth2/authorize"
assert discord_bp.token_url == "https://discord.com/api/oauth2/token"
assert discord_bp.authorization_url_params["prompt"] == None
assert discord_bp.authorization_url_params["prompt"] == "none"


def test_load_from_config(make_app):
Expand Down