feat(generator-single-spa): add skipGit#385
Open
eckdanny wants to merge 5 commits intosingle-spa:mainfrom
Open
feat(generator-single-spa): add skipGit#385eckdanny wants to merge 5 commits intosingle-spa:mainfrom
eckdanny wants to merge 5 commits intosingle-spa:mainfrom
Conversation
Was this intentional? The condition is always true so `_installDependencies` is always called. Verified by running: `pnpx create-single-spa@4.1.4 --moduleType util-module --skipInstall` ``` ? Directory for new project __test ? Which framework do you want to use? none ? Which package manager do you want to use? pnpm ? Will this project use Typescript? No ? Organization name (can use letters, numbers, dash or underscore) org ? Project name (can use letters, numbers, dash or underscore) proj Initialized empty Git repository in /Users/deck/Workspaces/create-single-spa/__test/.git/ Initialized git repository create __test/package.json create __test/jest.config.js create __test/babel.config.json create __test/.eslintrc create __test/.prettierignore create __test/.gitignore create __test/.husky/pre-commit create __test/webpack.config.js create __test/src/org-proj.js No change to package.json was detected. No package manager install will be executed. Skipping install command: pnpm install I'm all done. Just run pnpm install to install the required dependencies. ```
Adds the `skipGit` option to the SingleSpaGenerator. Refactors (dedupes + hoists) the git initialization routine. Moves git init to the `install` priority queue.
🦋 Changeset detectedLatest commit: 321591f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
eckdanny
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
skipGitoption.Closes #341.