Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note about copying limits #480

Merged
merged 2 commits into from
Mar 26, 2025
Merged

Add a note about copying limits #480

merged 2 commits into from
Mar 26, 2025

Conversation

kamilszymczak1
Copy link
Contributor

Copying problems from url keys does not copy contest-specific time or memory limits. Instead, the limits are set to the default package settings. In order to copy time limits with contest-specific settings, one has to go to a contest's problem list and choose the 'Attach to another contest' option.

This pull request adds a note about it displayed when adding problems through url keys.

It is a solution to the issue #471.

@kamilszymczak1 kamilszymczak1 self-assigned this Mar 6, 2025
@@ -104,7 +104,14 @@ class Meta(object):


class ProblemsetSourceForm(forms.Form):
url_key = forms.CharField(label=_("Enter problem's secret key"), required=True)
url_key = forms.CharField(label=_("Enter problem's secret key"),
help_text=("Please note that the time and memory limits will be copied\
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to use _ function to be able to translate this text, i.e.: _("Please note ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

Copy link
Contributor

@twalen twalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix translations issue

@twalen twalen merged commit 5e11282 into master Mar 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants