Skip to content

Handle JS libraries with webpack #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Jun 8, 2025
Merged

Conversation

stopnoanime
Copy link
Contributor

@stopnoanime stopnoanime commented Mar 16, 2025

Changes:

  • Bump jQuery to 1.12.4
  • Update clipboard to latest verison
  • Update highlight.js to latest version
  • Update marked to latest version
  • Update highchart.js to 4.1.10 (lowest version on npm)
  • Use js-cookie instead of depreciated jquery-cookie
  • Updated the bootstrap-datetimepicker library to its sucessor, Tempus Dominus.
  • Fixed some small timeline.js issues
  • Remove unused libs: jquery.storageapi, jquery-ui
  • Make ColorWidget use native color input
  • Added ESLint config
  • Make ./easy_toolbox.py run command run django and webpack concurrently
  • Cypress: Fixed bug in cypress github action that causes the workflow to pass if the webserver did not start
  • Added webpack and JS related docs

Won't fix for now:

  • ESLint: It found multiple issues in the codebase. Good material for a separate PR.
  • Liveranking module: Its dependencies are completely separate, so it can be modernized in a separate PR

Manual testing plan:

  • Clipboard.js: Test 'btn-copy' buttons
  • Bootstrap tooltips
  • Markdown editor, and code block highlighting in generated markdown: Used in portals
  • Bootstrap typeahead: Used in login as user form
  • Highcharts: Used in contest Statistics
  • js-cookie instead of jquery-cookie: Used for example in lagnauge picker
  • New color widget
  • Portal tree: need to enable portals
  • General functionality

@stopnoanime stopnoanime marked this pull request as ready for review April 23, 2025 14:15
@twalen twalen merged commit 1d7c23f into sio2project:master Jun 8, 2025
1 check passed
kamilszymczak1 pushed a commit that referenced this pull request Jun 30, 2025
* Handle jquery and bootstrap using webpack, update to jquery 1.12.4

* Handle typeahead, clipboard and highlight in webpack

* Use js-cookie instead of jquery.cookie

* remove unnecessary timeline dependencies

* Handle jqtree with webpack

* Use native colorPicker in ColorWidget

* Fix timeline.js wrong date function name

* Download bootstrap-markdown and marked with npm

* Add eslint

* Use only .css to load fontawesome

* Update highcharts.js to 4.1.10 (earliest version in npm)

* Cleanup and split some js scripts

* Revert timeline.js changes (will fix it in separate PR)

* Remove jshint in favour of eslint

* Make webpack run on container start, add easytoolbox webpack command

* Make django server and webpack run in a single shell

* Cypress Github Action timeout not failing fix

* Add webpack docs

* Change Docker compose setup to use doccker's node_modules

* Install concurrently with npm

* Fix balloons loading old jquery bundle

* Refactor DateTimePicker widget to use Tempus Dominus

* datetimepicker use language setting

* Change DateTimePicker format to match js time picker

* Use tempus dominus in timeline.js

* Change how we call datetimepicker setValue

* Share code between datetimepicker.js and timeline.js

* Readd custom_undo

* Load select2 using npm

* Remove unnecessary csslintrc entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants