SIO3Pack integration #288
Draft
SIO3Pack integration #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasloMaslane
commented
Mar 3, 2025
Comment on lines
18
to
19
| config = get_config() | ||
| if "sinol_task_id" in config: | ||
| return config["sinol_task_id"] | ||
| else: | ||
| print(util.warning("sinol_task_id not specified in config.yml. Using task id from directory name.")) | ||
| task_id = os.path.split(os.getcwd())[-1] | ||
| if len(task_id) == 3: | ||
| return task_id | ||
| else: | ||
| util.exit_with_error("Invalid task id. Task id should be 3 characters long.") | ||
| return Sio3Package().get_task_id() |
There was a problem hiding this comment.
sinol_task_id in config should still be handled
Comment on lines
56
to
48
| try: | ||
| with open(os.path.join(os.getcwd(), "config.yml"), "r") as config_file: | ||
| return yaml.load(config_file, Loader=yaml.FullLoader) or {} | ||
| except FileNotFoundError: | ||
| # Potentially redundant with util:exit_if_not_package | ||
| util.exit_with_error("You are not in a package directory (couldn't find config.yml in current directory).") | ||
| except yaml.YAMLError as e: | ||
| util.exit_with_error("config.yml is not a valid YAML. Fix it before continuing:\n" + str(e)) | ||
| return Sio3Package().get_config() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.